Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger contentUpdate on reviews load #21899

Merged
merged 1 commit into from
Mar 26, 2019
Merged

Trigger contentUpdate on reviews load #21899

merged 1 commit into from
Mar 26, 2019

Conversation

jahvi
Copy link

@jahvi jahvi commented Mar 22, 2019 •
edited
Loading

Description (*)

Reviews are being loaded asynchronously and since the HTML content is appended as is custom data-mage-init or text/x-magento-init scripts are not processed.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. Add any <script type="text/x-magento-init"> or data-mage-init attributes to the app/code/Magento/Review/view/frontend/templates/product/view/list.phtml file.
  2. Go to a product page with reviews.
  3. When reviews are loaded the custom scripts are loaded as part of the HTML and not executed.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 22, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @jahvi. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@jahvi
Copy link
Author

jahvi commented Mar 22, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @jahvi. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @jahvi, here is your new Magento instance.
Admin access: https://pr-21899.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@dmytro-ch dmytro-ch self-assigned this Mar 22, 2019
@dmytro-ch dmytro-ch self-requested a review March 22, 2019 16:36
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-4561 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@jahvi thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@soleksii soleksii self-assigned this Mar 25, 2019
@soleksii
Copy link

✔️ QA Passed

Result:

after

@nmalevanec nmalevanec self-assigned this Mar 25, 2019
@ghost
Copy link

ghost commented Mar 26, 2019

Hi @jahvi, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit 6e80c69 into magento:2.3-develop Mar 26, 2019
magento-engcom-team pushed a commit that referenced this pull request Mar 26, 2019
@sivaschenko
ENGCOM-4561: Trigger contentUpdate on reviews load #21899
24d2f5e
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Mar 26, 2019
@eduard13 eduard13 mentioned this pull request Mar 26, 2019
Merged
4 tasks
@jahvi jahvi deleted the fix/reviews-template-updatecontent branch March 26, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@nmalevanec nmalevanec

@dmytro-ch dmytro-ch

@soleksii soleksii

Labels
Area: Frontend Component: Review Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@jahvi @magento-cicd2 @magento-engcom-team @soleksii @dmytro-ch @nmalevanec